Ticket #147 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Contact list missing "+" for country code

Reported by: jaegermeisterjr Owned by: Deubeuliou
Priority: high Milestone: rev5
Component: phone_stack Version: trunk
Severity: major Keywords: sms plus sign sim import
Cc:

Description

If contacts are stored on the SIM in the format
+<country code><area code><phone number>, the plus sign is missing in the contact list and the phone numbers cannot be dailed, since they do not exist. For instance: The phone number
+91987654321
becomes
91987654321

If the SIM card is inserted in another phone, the plus sign is shown properly.

Change History

comment:1 Changed 3 years ago by jblondon

  • Status changed from new to assigned
  • Owner set to mbauer
  • Keywords sms plus sign sim import added

comment:2 Changed 2 years ago by jcassignol

  • Owner changed from mbauer to Deubeuliou

comment:3 Changed 2 years ago by jcassignol

  • Priority changed from normal to high
  • Version changed from rev4 to trunk
  • Severity changed from minor to major
  • Milestone set to rev5

comment:4 Changed 2 years ago by Deubeuliou

with libgsmd-tool -m atcmd,
AT+CPBR=1 returns:

RSTR=`+CPBR: 1,"336422*****",145,"Foo"'
RSTR=`+CPBR: 2,"846",129,"_serv.client"'
RSTR=`+CPBR: 3,"336769*****",145,"Bar/M"'
RSTR=`+CPBR: 4,"336892*****",145,"Moi"'
RSTR=`+CPBR: 5,"888",129,"Rpondeur/M"'
RSTR=`+CPBR: 6,"4917237*****",145,"Spam"'
RSTR=`+CPBR: 7,"3538763*****",145,"Egg"'
RSTR=`+CPBR: 8,"06251*****",129,"frisotte"'
RSTR=`+CPBR: 9,"336679*****",145,"frisottin"'
RSTR=`+CPBR: 10,"336141*****",145,"Mr. D"'

notice the 129 and the 145
in fact, trunk/src/core/gsm/include/libgsmd/phonebook.h contains an enum:

/* Refer to GSM 07.07 subclause 8.14 */
enum lgsm_pb_addr_type {	
	LGSM_PB_ATYPE_INTL		= 145,
	LGSM_PB_ATYPE_OTHE		= 129,
};

but is it isn't used anywhere

A simple fix will be to check whether the number is international or not and prepend a + or not.

comment:5 Changed 2 years ago by deubeuliou

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [1234]) Prefix with + in case of an international number. fixes #147 !!!

Note: See TracTickets for help on using tickets.